Adjust state hash computation bucket #3877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 2, 2025
Merged
Merged
ma2bd
approved these changes
May 5, 2025
afck
approved these changes
May 5, 2025
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
e83c215 to
3143c9d
Compare
ndr-ds
force-pushed
the
05-02-actually_use_backend_config
branch
from
fa5e6e5 to
40dc1bb
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
3143c9d to
a3d38ad
Compare
ndr-ds
force-pushed
the
05-02-actually_use_backend_config
branch
2 times, most recently
from
0c1bef2 to
80c2534
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
a3d38ad to
63ff628
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
63ff628 to
cd3ab06
Compare
ndr-ds
force-pushed
the
05-02-actually_use_backend_config
branch
3 times, most recently
from
5395c3f to
93d807b
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
cd3ab06 to
b7dd2db
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
b7dd2db to
f6712ff
Compare
ndr-ds
force-pushed
the
05-02-actually_use_backend_config
branch
from
93d807b to
8a865ae
Compare
This was referenced May 9, 2025
Contributor
Author
ndr-ds
changed the base branch from
05-02-actually_use_backend_config
to
graphite-base/3877
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
f6712ff to
e54c74f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This state hash computation can apparently take much longer than 10ms
Proposal
Adjust the bucket sizes to be more generous and catch larger values
Test Plan
CI + have deployed networks with this already
Release Plan